Skip to content

Upload sources even for binaries and failed builds #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2020
Merged

Upload sources even for binaries and failed builds #928

merged 2 commits into from
Aug 7, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Aug 2, 2020

Closes #607. Makes #520 much less of an issue (since it will only happen for crates built before this PR).

Tested with:

  • notcurses 1.6.10, a library that failed to build
  • bat 0.12.1, a binary
  • hexponent 0.3.0, a library that built successfully

@jyn514 jyn514 added A-builds Area: Building the documentation for a crate C-enhancement Category: This is a new feature S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Aug 2, 2020
Nemo157
Nemo157 reviewed Aug 4, 2020
View reviewed changes
@jyn514 jyn514 merged commit d23882c into rust-lang:master Aug 7, 2020
@jyn514 jyn514 deleted the source-view branch August 7, 2020 21:47
@jyn514 jyn514 mentioned this pull request Aug 15, 2020
Open
@jyn514 jyn514 mentioned this pull request Aug 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Nemo157 Nemo157 Nemo157 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A-builds Area: Building the documentation for a crate C-enhancement Category: This is a new feature S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The source view is not available when crate failed to build.
2 participants
@jyn514 @Nemo157